Reset the noEmitForJsFiles option when updating compiler options - #12570
Conversation
| this.cachedUnresolvedImportsPerFile.clear(); | ||
| this.lastCachedUnresolvedImportsList = undefined; | ||
| } | ||
| if (this.projectKind === ProjectKind.Inferred || this.projectKind === ProjectKind.Configured) { |
There was a problem hiding this comment.
This piece of code is similar to one in constructor - can you share it?
|
Can you add tests? |
6af0600 to
b0c8a19
Compare
| const diagsAfterUpdate = session.executeCommand(<server.protocol.CompilerOptionsDiagnosticsRequest>{ | ||
| type: "request", | ||
| command: server.CommandNames.CompilerOptionsDiagnosticsFull, | ||
| seq: 3, |
There was a problem hiding this comment.
I assume the "seq" number should increment with each request. You repeat "3" here (and also in the test below).
| this.markAsDirty(); | ||
| } | ||
|
|
||
| setInternalCompilerOptionsForEmittingJsFiles() { |
There was a problem hiding this comment.
private
|
Thanks Zhengbo Li (@zhengbli) . If we put this in the next VS RC, we'll need just this change off of the current commit in the package. Can you create a new branch (e.g. |
|
Sure, working on it. Edit: one minute, let me do a final round of local testing to be sure no surprise again. |
|
Bill Ticehurst (@billti) I created https://github.com/Microsoft/TypeScript/tree/vs/release-2.1 that has the changes in this PR. Thank you! |
4 participants
No description provided.